clolov commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1553235267
########## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ########## @@ -1568,10 +1548,8 @@ public void shouldNotShareHeadersBetweenPunctuateIterations() { @Test public void shouldWrapKafkaExceptionWithStreamsExceptionWhenProcess() { - EasyMock.expect(stateManager.changelogPartitions()).andReturn(Collections.emptySet()).anyTimes(); - EasyMock.expect(stateManager.changelogOffsets()).andReturn(emptyMap()).anyTimes(); - EasyMock.expect(recordCollector.offsets()).andReturn(emptyMap()).anyTimes(); - EasyMock.replay(stateManager, recordCollector); + when(stateManager.changelogOffsets()).thenReturn(emptyMap()); + when(recordCollector.offsets()).thenReturn(emptyMap()); Review Comment: This is also absolutely correct, these are not needed. I have removed all stub-related references to emptyMap -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org