dongnuo123 commented on code in PR #15411: URL: https://github.com/apache/kafka/pull/15411#discussion_r1554638676
########## core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala: ########## @@ -1831,6 +1832,22 @@ class KafkaConfigTest { assertTrue(config.isNewGroupCoordinatorEnabled) } + @Test + def testGroupProtocolMigrationPolicy(): Unit = { + val props = new Properties() + props.putAll(kraftProps()) + + // Invalid GroupProtocolMigrationPolicy value. + props.put(KafkaConfig.ConsumerGroupMigrationPolicyProp, "foo") + assertThrows(classOf[ConfigException], () => KafkaConfig.fromProps(props)) + + ConsumerGroupMigrationPolicy.values().foreach { policy => + props.put(KafkaConfig.ConsumerGroupMigrationPolicyProp, policy.toString) Review Comment: Though it's not in `ConsumerGroupMigrationPolicy#parse`, in this test `KafkaConfig.fromProps` requires case sensitivity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org