brandboat commented on code in PR #15668:
URL: https://github.com/apache/kafka/pull/15668#discussion_r1554644159
##########
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##########
@@ -112,7 +113,7 @@ public ClientMetricsManager(ClientMetricsReceiverPlugin
receiverPlugin, int clie
this.subscriptionMap = new ConcurrentHashMap<>();
this.subscriptionUpdateVersion = new AtomicInteger(0);
this.clientInstanceCache = new SynchronizedCache<>(new
LRUCache<>(CACHE_MAX_SIZE));
- this.expirationTimer = new SystemTimerReaper("client-metrics-reaper",
new SystemTimer("client-metrics"));
+ this.expirationTimer = new
SystemTimerReaper(CLIENT_METRICS_REAPER_THREAD_NAME, new
SystemTimer("client-metrics"));
Review Comment:
Already add a test in 5f220e297990311d631544582ac27d11473ebea4 while the
test need some additional methods to check if executorservice/thread is
shutdown or not. Or maybe we can simply add `executor-` (the thread prefix used
by SystemTimer ) to `unexpectedThreadNames`. Let the unexpectedThreadNames to
check if thread are cleanup or not.
https://github.com/apache/kafka/blob/dc189a39cc79d45c59fa1762ca9379bdbd85ee34/server-common/src/main/java/org/apache/kafka/server/util/timer/SystemTimer.java#L52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
