dongnuo123 commented on code in PR #15587: URL: https://github.com/apache/kafka/pull/15587#discussion_r1555019741
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ########## @@ -2415,6 +2415,20 @@ private CoordinatorResult<Void, Record> classicGroupJoinExistingMember( return EMPTY_RESULT; } + /** + * An overload of {@link GroupMetadataManager#completeClassicGroupJoin(ClassicGroup)} used as + * timeout operation. It additionally looks up the group by the id and checks the group type. + * completeClassicGroupJoin will only be called if the group is CLASSIC. + */ + private CoordinatorResult<Void, Record> completeClassicGroupJoin(String groupId) { + if (containsClassicGroup(groupId)) { + return completeClassicGroupJoin(getOrMaybeCreateClassicGroup(groupId, false)); Review Comment: Yes I agree. Let me use the try catch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org