OmniaGM commented on code in PR #15670:
URL: https://github.com/apache/kafka/pull/15670#discussion_r1556478763
##########
transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionLogConfig.java:
##########
@@ -16,11 +16,43 @@
*/
package org.apache.kafka.coordinator.transaction;
+import org.apache.kafka.common.config.TopicConfig;
+import org.apache.kafka.server.config.ServerTopicConfigSynonyms;
+import org.apache.kafka.storage.internals.log.ProducerStateManagerConfig;
+
public class TransactionLogConfig {
Review Comment:
Adding "s" to the name make sense but seems like we don't have one pattern
in Kafka for example there is SaslConfigs and TopicConfig. I'll rename it but
we properly need to update https://issues.apache.org/jira/browse/KAFKA-14524 to
add some guidance for future refactors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
