jolshan commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1556609642
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -979,6 +1013,13 @@ void handleCoordinatorReady() {
null;
this.coordinatorSupportsBumpingEpoch = initProducerIdVersion != null &&
initProducerIdVersion.maxVersion() >= 3;
+
+ // TODO(caliu) use feature version.
+ ApiVersion produceVersion = nodeApiVersions != null ?
+ nodeApiVersions.apiVersion(ApiKeys.PRODUCE) :
+ null;
+ this.coordinatorSupportsTransactionV2 = produceVersion != null &&
Review Comment:
We should also be checking the TV on the various requests and making sure we
check the epoch when we update the cluster's latest TV.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
