chia7712 commented on PR #15645: URL: https://github.com/apache/kafka/pull/15645#issuecomment-2044427643
> Are you suggest to rewrite command and all tests to java but keep one test in scala? Let's rewrite all code to java. Seems, like PR ready to review and merge :) I prefer to don't touch it. This class is all about zk and we can remove it once we remove zk support. > Can you, please, clarify - are you suggest to extend ConfigCommandIntegrationTest to test cases with broker configs? If we decide to rewrite this test in java, can we extend it after merge? Or you want to create more test cases for scala version? It seems to me using Java to write integration test for broker configs is the better way. One more thing, we can add deprecation annotation to this class to remind developers that this IT is all about zk and we will remove it in next major release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
