chia7712 commented on code in PR #15687:
URL: https://github.com/apache/kafka/pull/15687#discussion_r1557608588
##########
core/src/test/java/kafka/test/ClusterTestExtensionsTest.java:
##########
@@ -89,20 +91,24 @@ public void testClusterTemplate() {
}),
@ClusterTest(name = "cluster-tests-2", clusterType = Type.KRAFT,
serverProperties = {
@ClusterConfigProperty(key = "foo", value = "baz"),
- @ClusterConfigProperty(key = "spam", value = "eggz")
+ @ClusterConfigProperty(key = "spam", value = "eggz"),
+ @ClusterConfigProperty(key = "default.key", value =
"overwrite.value")
}),
@ClusterTest(name = "cluster-tests-3", clusterType = Type.CO_KRAFT,
serverProperties = {
@ClusterConfigProperty(key = "foo", value = "baz"),
- @ClusterConfigProperty(key = "spam", value = "eggz")
+ @ClusterConfigProperty(key = "spam", value = "eggz"),
+ @ClusterConfigProperty(key = "default.key", value =
"overwrite.value")
})
})
public void testClusterTests() {
if
(clusterInstance.clusterType().equals(ClusterInstance.ClusterType.ZK)) {
Assertions.assertEquals(clusterInstance.config().serverProperties().getProperty("foo"),
"bar");
Assertions.assertEquals(clusterInstance.config().serverProperties().getProperty("spam"),
"eggs");
+
Assertions.assertEquals(clusterInstance.config().serverProperties().getProperty("default.key"),
"default.value");
Review Comment:
the first argument is "expected", and so `default.value` should be the first
input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
