soarez commented on code in PR #15718: URL: https://github.com/apache/kafka/pull/15718#discussion_r1565822707
########## docs/ops.html: ########## @@ -2126,7 +2142,7 @@ <h5 class="anchor-heading"><a id="kraft_controller_monitoring" class="anchor-lin <tr> <td>Offline Partition Count</td> <td>The number of offline topic partitions (non-internal) as observed by this Controller.</td> - <td>kafka.controller:type=KafkaController,name=OfflinePartitionCount</td> + <td>kafka.controller:type=KafkaController,name=OfflinePartitionsCount</td> Review Comment: https://github.com/apache/kafka/blob/3617dda9a5415ee1597967f754985fb73a5350c6/core/src/main/scala/kafka/controller/KafkaController.scala#L74 ########## docs/ops.html: ########## @@ -2113,6 +2113,22 @@ <h5 class="anchor-heading"><a id="kraft_controller_monitoring" class="anchor-lin <td>The number of active brokers as observed by this Controller.</td> <td>kafka.controller:type=KafkaController,name=ActiveBrokerCount</td> </tr> + <tr> + <td>Migrating ZK Broker Count</td> + <td>The number of brokers registered with the Controller that haven't yet migrated to KRaft mode.</td> + <td>kafka.controller:type=KafkaController,name=MigratingZkBrokerCount</td> + </tr> + <tr> + <td>ZK Migrating State</td> + <td> + 0 - NONE, cluster created in KRaft mode; + 4 - ZK, Migration has not started, controller is a ZK controller. + 2 - PRE_MIGRATION, the KRaft Controller is waiting for all ZK brokers to register in migration mode; + 1 - MIGRATION, ZK metadata has been migrated, but some broker is still running in ZK mode; + 3 - POST_MIGRATION, the cluster migration is complete; + </td> + <td>kafka.controller:type=KafkaController,name=ZkMigrationState</td> Review Comment: https://github.com/apache/kafka/blob/3617dda9a5415ee1597967f754985fb73a5350c6/metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetrics.java#L54-L55 ########## docs/ops.html: ########## @@ -2113,6 +2113,22 @@ <h5 class="anchor-heading"><a id="kraft_controller_monitoring" class="anchor-lin <td>The number of active brokers as observed by this Controller.</td> <td>kafka.controller:type=KafkaController,name=ActiveBrokerCount</td> </tr> + <tr> + <td>Migrating ZK Broker Count</td> + <td>The number of brokers registered with the Controller that haven't yet migrated to KRaft mode.</td> + <td>kafka.controller:type=KafkaController,name=MigratingZkBrokerCount</td> + </tr> + <tr> + <td>ZK Migrating State</td> + <td> + 0 - NONE, cluster created in KRaft mode; + 4 - ZK, Migration has not started, controller is a ZK controller. + 2 - PRE_MIGRATION, the KRaft Controller is waiting for all ZK brokers to register in migration mode; + 1 - MIGRATION, ZK metadata has been migrated, but some broker is still running in ZK mode; + 3 - POST_MIGRATION, the cluster migration is complete; Review Comment: https://github.com/apache/kafka/blob/3617dda9a5415ee1597967f754985fb73a5350c6/metadata/src/main/java/org/apache/kafka/metadata/migration/ZkMigrationState.java#L33-L72 ########## docs/ops.html: ########## @@ -2113,6 +2113,22 @@ <h5 class="anchor-heading"><a id="kraft_controller_monitoring" class="anchor-lin <td>The number of active brokers as observed by this Controller.</td> <td>kafka.controller:type=KafkaController,name=ActiveBrokerCount</td> </tr> + <tr> + <td>Migrating ZK Broker Count</td> + <td>The number of brokers registered with the Controller that haven't yet migrated to KRaft mode.</td> + <td>kafka.controller:type=KafkaController,name=MigratingZkBrokerCount</td> Review Comment: https://github.com/apache/kafka/blob/3617dda9a5415ee1597967f754985fb73a5350c6/metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetrics.java#L42-L43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org