[ 
https://issues.apache.org/jira/browse/KAFKA-16560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837553#comment-17837553
 ] 

Kuan Po Tseng commented on KAFKA-16560:
---------------------------------------

Thanks [~chia7712], in https://github.com/apache/kafka/pull/15715, currently 
I'm working on making ClusterConfig immutable. Like you mentioned in pr 
comment, there are still plenty of places like BrokerNode, ControllerNode are 
not immutable. We can continue the work in this JIRA.

> Refactor/cleanup BrokerNode/ControllerNode/ClusterConfig
> --------------------------------------------------------
>
>                 Key: KAFKA-16560
>                 URL: https://issues.apache.org/jira/browse/KAFKA-16560
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Minor
>
> origin discussion: 
> https://github.com/apache/kafka/pull/15715#discussion_r1564660916
> It seems to me this jira should address following tasks.
> 1. make them immutable. We have adopted the builder pattern, so all changes 
> should be completed in the builder phase
> 2. make all `Builder#build()` not accept any arguments. Instead, we should 
> add new setters for those arguments.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to