chia7712 commented on code in PR #15729:
URL: https://github.com/apache/kafka/pull/15729#discussion_r1567300055
##########
build.gradle:
##########
@@ -1239,6 +1239,9 @@ project(':core') {
}
}
}
+ // -parameters generates arguments with parameter names in
TestInfo#getDisplayName.
+ // ref:
https://github.com/junit-team/junit5/blob/4c0dddad1b96d4a20e92a2cd583954643ac56ac0/junit-jupiter-params/src/main/java/org/junit/jupiter/params/ParameterizedTest.java#L161-L164
+ compileTestScala.options.compilerArgs.add "-parameters"
Review Comment:
Instead of adding the args to core module directly, could we define the
compile args in `ScalaCompile`? we can add condition check to make sure the
`-parameters` is added to test only. For example:
```
if (name == "compileTestScala")
options.compilerArgs << "-parameters"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
