chia7712 commented on code in PR #15634:
URL: https://github.com/apache/kafka/pull/15634#discussion_r1567414802
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -1223,6 +1223,12 @@ class UnifiedLog(@volatile var logStartOffset: Long,
s"but we only have log segments starting from offset:
$logStartOffset.")
}
+ private def checkLocalLogStartOffset(offset: Long): Unit = {
Review Comment:
It seems reading records between [logStartOffset, localLogStartOffset] is
dangerous since the segment won't be in local-disk. That is a bit chaos to me
as `UnifiedLog` presents a unified view of local and tiered log segment
(https://github.com/apache/kafka/blob/fccd7fec666d6570758e0b7891771099240ceee8/core/src/main/scala/kafka/log/UnifiedLog.scala#L59).
The check looks like a limit that we can't "view" data from tiered log segment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
