soarez commented on PR #15719: URL: https://github.com/apache/kafka/pull/15719#issuecomment-2063477565
Thanks for the changes. You have some compilation errors: ``` [2024-04-17T15:27:16.786Z] > Task :jmh-benchmarks:compileJava [2024-04-17T15:27:16.786Z] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-15719/jmh-benchmarks/src/main/java/org/apache/kafka/jmh/server/CheckpointBench.java:110: error: method createLogManager in class TestUtils cannot be applied to given types; [2024-04-17T15:27:16.786Z] this.logManager = TestUtils.createLogManager(JavaConverters.asScalaBuffer(files), [2024-04-17T15:27:16.786Z] ^ [2024-04-17T15:27:16.786Z] required: Seq<File>,LogConfig,ConfigRepository,CleanerConfig,MockTime,MetadataVersion,int,boolean,Option<UnifiedLog>,boolean,long [2024-04-17T15:27:16.786Z] found: Buffer<File>,LogConfig,MockConfigRepository,CleanerConfig,MockTime,MetadataVersion,int,boolean,Option<Object>,boolean [2024-04-17T15:27:16.786Z] reason: actual and formal argument lists differ in length [2024-04-17T15:27:16.786Z] 1 error ``` Can you address these? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
