chia7712 commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1573465553
##########
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java:
##########
@@ -1012,6 +1013,28 @@ public void testChannelCloseWhileProcessingReceives()
throws Exception {
assertEquals(0, selector.completedReceives().size());
}
+ /**
+ * Validate that correct subset of io metrics marked deprecated in docs
+ */
+ @Test
+ public void testIoMetricsHaveCorrectDoc() {
+ List<String> actual = asList("io-ratio", "io-wait-ratio");
+ List<String> deprecated = asList("iotime-total", "io-waittime-total");
+
+ // iterate through all metrics, since metrics.metric(metricName)
requires
+ // knowing metric group and tag set, which are not trivial dependencies
+ for (MetricName metricName : metrics.metrics().keySet()) {
Review Comment:
> However, I'm concerning that if at some point all of them are removed, the
test will stop doing anything meaningful without showing any sign of it. But I
don't see an elegant trigger to show it.
It seems to me making the test failed can remind developer - "oh, this test
is failed and it unnecessary since I have removed those metrics from
production".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
