chia7712 commented on PR #15772: URL: https://github.com/apache/kafka/pull/15772#issuecomment-2068139760
``` Code Warning FS Format string should use %n rather than \n in org.apache.kafka.network.SocketServerConfigs.<static initializer for SocketServerConfigs>() [Bug type VA_FORMAT_STRING_USES_NEWLINE (click for details)](file:///home/chia7712/project/kafka/server/build/reports/spotbugs/main.html#VA_FORMAT_STRING_USES_NEWLINE) In class org.apache.kafka.network.SocketServerConfigs In method org.apache.kafka.network.SocketServerConfigs.<static initializer for SocketServerConfigs>() Called method String.format(String, Object[]) Format string " If the listener name is not a security protocol, <code>%s</code> must also be set.\n" At SocketServerConfigs.java:[line 48] FS Format string should use %n rather than \n in org.apache.kafka.network.SocketServerConfigs.<static initializer for SocketServerConfigs>() [Bug type VA_FORMAT_STRING_USES_NEWLINE (click for details)](file:///home/chia7712/project/kafka/server/build/reports/spotbugs/main.html#VA_FORMAT_STRING_USES_NEWLINE) In class org.apache.kafka.network.SocketServerConfigs In method org.apache.kafka.network.SocketServerConfigs.<static initializer for SocketServerConfigs>() Called method String.format(String, Object[]) Format string "Listeners to publish to ZooKeeper for clients to use, if different than the <code>%s</code> config property. In IaaS environments, this may need to be different from the interface to which the broker binds. If this is not set, the value for <code>%1$1s</code> will be used. Unlike <code>%1$1s</code>, it is not valid to advertise the 0.0.0.0 meta-address.\n Also unlike <code>%1$1s</code>, there can be duplicated ports in this property, so that one listener can be configured to advertise another listener's address. This can be useful in some cases where external load balancers are used." At SocketServerConfigs.java:[line 60] FS Format string should use %n rather than \n in org.apache.kafka.network.SocketServerConfigs.<static initializer for SocketServerConfigs>() [Bug type VA_FORMAT_STRING_USES_NEWLINE (click for details)](file:///home/chia7712/project/kafka/server/build/reports/spotbugs/main.html#VA_FORMAT_STRING_USES_NEWLINE) In class org.apache.kafka.network.SocketServerConfigs In method org.apache.kafka.network.SocketServerConfigs.<static initializer for SocketServerConfigs>() Called method String.format(String, Object[]) Format string "Name of listener used for communication between controller and brokers. A broker will use the <code>%s</code> to locate the endpoint in $ListenersProp list, to listen for connections from the controller. For example, if a broker's config is:\n<code>listeners = INTERNAL://192.1.1.8:9092, EXTERNAL://10.1.1.5:9093, CONTROLLER://192.1.1.8:9094listener.security.protocol.map = INTERNAL:PLAINTEXT, EXTERNAL:SSL, CONTROLLER:SSLcontrol.plane.listener.name = CONTROLLER</code>\nOn startup, the broker will start listening on "192.1.1.8:9094" with security protocol "SSL".\nOn the controller side, when it discovers a broker's published endpoints through ZooKeeper, it will use the <code>%1$1s</code> to find the endpoint, which it will use to establish connection to the broker.\nFor example, if the broker's published endpoints on ZooKeeper are:\n <code>"endpoints" : ["INTERNAL://broker1.example.com:9092","EXTERNAL://broker1.example.com:9093","CONTROLLER://broker1.example.com:9094"]< /code>\n and the controller's config is:\n<code>listener.security.protocol.map = INTERNAL:PLAINTEXT, EXTERNAL:SSL, CONTROLLER:SSLcontrol.plane.listener.name = CONTROLLER</code>\nthen the controller will use "broker1.example.com:9094" with security protocol "SSL" to connect to the broker.\nIf not explicitly configured, the default value will be null and there will be no dedicated endpoints for controller connections.\nIf explicitly configured, the value cannot be the same as the value of <code>%s</code>." At SocketServerConfigs.java:[line 71] ``` There are build error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org