mimaison commented on code in PR #15786: URL: https://github.com/apache/kafka/pull/15786#discussion_r1577660497
########## core/src/main/scala/kafka/zookeeper/ZooKeeperClient.scala: ########## @@ -52,8 +51,8 @@ object ZooKeeperClient { * @param sessionTimeoutMs session timeout in milliseconds * @param connectionTimeoutMs connection timeout in milliseconds * @param maxInFlightRequests maximum number of unacknowledged requests the client will send before blocking. + * @param clientConfig ZooKeeper client configuration, for TLS configs if desired Review Comment: To be honest, I considered not touching that file at all since we expect to delete it soon. I wouldn't spend too much time cleaning it up, so I'll ignore these other issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org