showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1579325677
##########
core/src/test/scala/unit/kafka/server/TierStateMachineTest.scala:
##########
@@ -153,12 +157,13 @@ class ReplicaFetcherTierStateMachineTest {
assertEquals(11L, replicaState.logEndOffset)
}
- @Test
- def testFencedOffsetResetAfterMovedToRemoteTier(): Unit = {
+ @ParameterizedTest
+ @ArgumentsSource(classOf[TierStateMachineTest.Params])
+ def testFencedOffsetResetAfterMovedToRemoteTier(truncateOnFetch: Boolean,
useFutureLog: Boolean): Unit = {
val partition = new TopicPartition("topic", 0)
var isErrorHandled = false
val mockLeaderEndpoint = new MockLeaderEndPoint(truncateOnFetch =
truncateOnFetch, version = version)
- val mockTierStateMachine = new MockTierStateMachine(mockLeaderEndpoint) {
+ val mockTierStateMachine = new MockTierStateMachine(mockLeaderEndpoint,
useFutureLog) {
Review Comment:
Unfortunately, you're correct! Removed the `useFutureLog`. I'll think about
how to do unit test for it. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
