brandboat commented on code in PR #15761: URL: https://github.com/apache/kafka/pull/15761#discussion_r1580532456
########## core/src/test/java/kafka/test/ClusterTestExtensionsTest.java: ########## @@ -48,14 +51,18 @@ public class ClusterTestExtensionsTest { // Static methods can generate cluster configurations static void generate1(ClusterGenerator clusterGenerator) { - clusterGenerator.accept(ClusterConfig.defaultClusterBuilder().name("Generated Test").build()); + Map<String, String> serverProperties = new HashMap<>(); + serverProperties.put("foo", "bar"); + clusterGenerator.accept(ClusterConfig.defaultBuilder() + .setName("Generated Test") + .setServerProperties(serverProperties) + .build()); } // BeforeEach run after class construction, but before cluster initialization and test invocation @BeforeEach public void beforeEach(ClusterConfig config) { Review Comment: Make sense to me. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org