rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1581140616
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##########
@@ -966,6 +987,23 @@ private static void maybeUpdateSubscribedTopicNames(
}
}
+ /**
+ * Updates the subscription type, iff necessary.
+ *
+ * If all members are subscribed to the same set of topics, the type is
homogeneous.
+ * Otherwise, it is heterogeneous.
+ */
+ private void maybeUpdateGroupSubscriptionType() {
Review Comment:
hmm theoretically yes, but what if it stays homo/hetero even after the
update? maybe it doesn't matter cause the variable is reassigned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
