chia7712 commented on code in PR #15800: URL: https://github.com/apache/kafka/pull/15800#discussion_r1582294569
########## core/src/test/java/kafka/test/junit/ClusterTestExtensions.java: ########## @@ -91,9 +91,6 @@ public Stream<TestTemplateInvocationContext> provideTestTemplateInvocationContex ClusterTemplate clusterTemplateAnnot = context.getRequiredTestMethod().getDeclaredAnnotation(ClusterTemplate.class); if (clusterTemplateAnnot != null) { processClusterTemplate(context, clusterTemplateAnnot, generatedContexts::add); - if (generatedContexts.isEmpty()) { - throw new IllegalStateException("ClusterConfig generator method should provide at least one config"); Review Comment: My previous comment is wrong. This check is used to make sure there is at least one `ClusterConfig`, so we should not remove it. However, It seems to me this check should be moved to `processClusterTemplate` and we should add unit test for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org