chiacyu commented on code in PR #15823:
URL: https://github.com/apache/kafka/pull/15823#discussion_r1583157619
##########
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##########
@@ -584,27 +584,6 @@ public static String formatBytes(long bytes) {
}
}
- /**
- * Create a string representation of an array joined by the given separator
- * @param strs The array of items
- * @param separator The separator
- * @return The string representation.
- */
- public static <T> String join(T[] strs, String separator) {
- return join(Arrays.asList(strs), separator);
- }
-
- /**
- * Create a string representation of a collection joined by the given
separator
- * @param collection The list of items
- * @param separator The separator
- * @return The string representation.
- */
- public static <T> String join(Collection<T> collection, String separator) {
- Objects.requireNonNull(collection);
- return mkString(collection.stream(), "", "", separator);
- }
-
/**
* Create a string representation of a stream surrounded by `begin` and
`end` and joined by `separator`.
*
Review Comment:
I looked up the code base and found there're almost dozens use cases of
`Utils.mkString()`. Should we remove that too? If so, is that a better
representation to eliminate it in another PR? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
