chia7712 commented on code in PR #15773:
URL: https://github.com/apache/kafka/pull/15773#discussion_r1583431374
##########
server-common/src/main/java/org/apache/kafka/server/config/ServerLogConfigs.java:
##########
@@ -86,7 +86,7 @@ public class ServerLogConfigs {
public static final String LOG_DELETE_DELAY_MS_CONFIG =
ServerTopicConfigSynonyms.serverSynonym(TopicConfig.FILE_DELETE_DELAY_MS_CONFIG);
public static final long LOG_DELETE_DELAY_MS_DEFAULT = 60000L;
- public static final String LOG_DELETE_DELAY_MS_DOC = "The amount of time
to wait before deleting a file from the filesystem";
+ public static final String LOG_DELETE_DELAY_MS_DOC = "The amount of time
to wait before deleting a file from the filesystem. If the value is 0 and there
is no file to delete, the system will wait 1 second, or the job may keep
running.";
Review Comment:
"1 second"? or "1 millisecond"?
Also, we need to highlight "busy waiting" for users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
