raminqaf commented on PR #15601: URL: https://github.com/apache/kafka/pull/15601#issuecomment-2084636567
@gharris1727 Thanks for the positive feedback! I am happy that you like the changes! I addressed all your nit reviews and refactored the logic of the non-final boolean variables (i.e., `needOuterJoin`, `outerJoinLeftWindowOpen`, `outerJoinRightWindowOpen`). Please have a look! Tiny knowledge sharing: The `LeftOrRightValue` class represents a union type (either left or right and can be both simultaneouslye). In Java 21+ (I know very high Java version :D) , this is solved with sealed interfaces and records. I was reading this article recently and thought about the class: https://ifesunmola.com/sum-types-in-java/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
