[ https://issues.apache.org/jira/browse/KAFKA-16604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842412#comment-17842412 ]
Chris Egerton commented on KAFKA-16604: --------------------------------------- We don't necessarily have to deprecate anything. It's a little awkward to support all the {{ConfigDef::define}} variants and a builder pattern for {{{}ConfigKey{}}}, but this would produce no breaking changes and provide a path forward that doesn't run the risk of accidental compatibility violations like in KAFKA-16592. IMO that would be a reasonable compromise. Regardless, I agree with the root sentiment of this ticket (that we should probably change direction in how we evolve these two classes). Would love to discuss further on a KIP thread! > Deprecate ConfigDef.ConfigKey constructor from public APIs > ---------------------------------------------------------- > > Key: KAFKA-16604 > URL: https://issues.apache.org/jira/browse/KAFKA-16604 > Project: Kafka > Issue Type: Improvement > Reporter: Sagar Rao > Assignee: Sagar Rao > Priority: Major > > Currently, one can create ConfigKey by either invoking the public constructor > directly and passing it to a ConfigDef object or by invoking the a bunch of > define methods. The 2 ways can get confusing at times. Moreover, it could > lead to errors as was noticed in KAFKA-16592 > We should ideally have only 1 way exposed to the users which IMO should be to > create the objects only through the exposed define methods. This ticket is > about marking the public constructor of ConfigKey as Deprecated first and > then making it private eventually. -- This message was sent by Atlassian Jira (v8.20.10#820010)