kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1586622390
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1273,6 +1228,22 @@ private void close(Duration timeout, boolean
swallowException) {
if (applicationEventHandler != null)
closeQuietly(() ->
applicationEventHandler.close(Duration.ofMillis(closeTimer.remainingMs())),
"Failed shutting down network thread", firstException);
closeTimer.update();
+
+ // close() can be called from inside one of the constructors. In that
case, it's possible that neither
+ // the reaper nor the background event queue were constructed, so
check them first to avoid NPE.
+ if (backgroundEventReaper != null && backgroundEventQueue != null) {
+ // Copy over the completable events to a separate list, then reap
any incomplete
+ // events on that list.
+ LinkedList<BackgroundEvent> allEvents = new LinkedList<>();
Review Comment:
Yes, because it has the `drainTo()` method. However, this code is now gone,
so it's moot 🤷♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
