mjsax commented on code in PR #14360:
URL: https://github.com/apache/kafka/pull/14360#discussion_r1586935977
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -240,24 +240,29 @@ <h4><a class="toc-backref"
href="#id23">num.standby.replicas</a><a class="header
</tr>
</thead>
<tbody valign="top">
- <tr class="row-odd"><td>acceptable.recovery.lag</td>
+ <tr class="row-even"><td>acceptable.recovery.lag</td>
<td>Medium</td>
<td colspan="2">The maximum acceptable lag (number of offsets to
catch up) for an instance to be considered caught-up and ready for the active
task.</td>
<td><code class="docutils literal"><span
class="pre">10000</span></code></td>
</tr>
- <tr class="row-even"><td>application.server</td>
+ <tr class="row-odd"><td>application.server</td>
<td>Low</td>
<td colspan="2">A host:port pair pointing to an embedded user
defined endpoint that can be used for discovering the locations of
state stores within a single Kafka Streams application. The
value of this must be different for each instance
of the application.</td>
<td>the empty string</td>
</tr>
- <tr class="row-odd"><td>buffered.records.per.partition</td>
+ <tr class="row-even"><td>buffered.records.per.partition</td>
<td>Low</td>
<td colspan="2">The maximum number of records to buffer per
partition.</td>
<td><code class="docutils literal"><span
class="pre">1000</span></code></td>
</tr>
- <tr class="row-even"><td>cache.max.bytes.buffering</td>
+ <tr class="row-odd"><td>statestore.cache.max.bytes</td>
+ <td>Medium</td>
+ <td colspan="2">Maximum number of memory bytes to be used for
record caches across all threads.</td>
+ <td>10485760</td>
+ </tr>
+ <tr class="row-even"><td>cache.max.bytes.buffering (Deprecated. Use
cache.max.bytes instead.)</td>
Review Comment:
```suggestion
<tr class="row-even"><td>cache.max.bytes.buffering (Deprecated.
Use statestore.cache.max.bytes instead.)</td>
```
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -564,25 +565,22 @@ public class StreamsConfig extends AbstractConfig {
static final String DSL_STORE_SUPPLIERS_CLASS_DOC = "Defines which store
implementations to plug in to DSL operators. Must implement the
<code>org.apache.kafka.streams.state.DslStoreSuppliers</code> interface.";
static final Class<?> DSL_STORE_SUPPLIERS_CLASS_DEFAULT =
BuiltInDslStoreSuppliers.RocksDBDslStoreSuppliers.class;
- /** {@code default.windowed.key.serde.inner} */
+ /** {@code default.windowed.key.serde.inner
+ * @deprecated since 3.0.0} */
@SuppressWarnings("WeakerAccess")
@Deprecated
public static final String DEFAULT_WINDOWED_KEY_SERDE_INNER_CLASS =
"default.windowed.key.serde.inner";
private static final String DEFAULT_WINDOWED_KEY_SERDE_INNER_CLASS_DOC =
"Default serializer / deserializer for the inner class of a windowed key. Must
implement the " +
"<code>org.apache.kafka.common.serialization.Serde</code> interface.";
- /** {@code default.windowed.value.serde.inner} */
+ /** {@code default.windowed.value.serde.inner
+ * @deprecated since 3.0.0 } */
@SuppressWarnings("WeakerAccess")
@Deprecated
public static final String DEFAULT_WINDOWED_VALUE_SERDE_INNER_CLASS =
"default.windowed.value.serde.inner";
private static final String DEFAULT_WINDOWED_VALUE_SERDE_INNER_CLASS_DOC =
"Default serializer / deserializer for the inner class of a windowed value.
Must implement the " +
"<code>org.apache.kafka.common.serialization.Serde</code> interface.";
- public static final String WINDOWED_INNER_CLASS_SERDE =
"windowed.inner.class.serde";
Review Comment:
Seems we cannot just remove it, but also marked as deprecated only instead?
Also, given that deprecation is part of KIP-1020, should this be only done in
the KIP-1020 PR, and this PR would only do the docs cleanup?
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -326,8 +331,15 @@ <h4><a class="toc-backref"
href="#id23">num.standby.replicas</a><a class="header
the
<code>org.apache.kafka.streams.state.DslStoreSuppliers</code> interface.
</td>
<td><code>BuiltInDslStoreSuppliers.RocksDBDslStoreSuppliers</code></td>
+ <td colspan="2">Default serializer/deserializer for the inner
class of windowed keys, implementing the <code class="docutils literal"><span
class="pre">Serde</span></code> interface.</td>
Review Comment:
Seems this line does not belong to `dsl.store.suppliers.class` config?
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -300,7 +305,7 @@ <h4><a class="toc-backref"
href="#id23">num.standby.replicas</a><a class="header
set by the user or all serdes must be passed in explicitly (see
also default.key.serde).</td>
<td><code class="docutils literal"><span
class="pre">null</span></code></td>
</tr>
- <tr class="row-even"><td>default.windowed.key.serde.inner</td>
+ <tr class="row-even"><td>default.windowed.key.serde.inner
(Deprecated.)</td>
Review Comment:
Below is `default.window.value.serde.inner` which was also deprecated,
right? (L308 original, new L313)
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -326,8 +331,15 @@ <h4><a class="toc-backref"
href="#id23">num.standby.replicas</a><a class="header
the
<code>org.apache.kafka.streams.state.DslStoreSuppliers</code> interface.
</td>
<td><code>BuiltInDslStoreSuppliers.RocksDBDslStoreSuppliers</code></td>
+ <td colspan="2">Default serializer/deserializer for the inner
class of windowed keys, implementing the <code class="docutils literal"><span
class="pre">Serde</span></code> interface.</td>
+ <td>null</td>
</tr>
- <tr class="row-even"><td>max.task.idle.ms</td>
+ <tr class="row-even"><td>default.windowed.value.serde.inner
(Deprecated.)</td>
Review Comment:
It seems `default.windowed.value.serde.inner` exist already? Why do we add
it here?
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -647,7 +645,8 @@ public class StreamsConfig extends AbstractConfig {
@SuppressWarnings("WeakerAccess")
public static final String METRICS_SAMPLE_WINDOW_MS_CONFIG =
CommonClientConfigs.METRICS_SAMPLE_WINDOW_MS_CONFIG;
- /** {@code auto.include.jmx.reporter} */
+ /** {@code auto.include.jmx.reporter
+ * @deprecated and will removed in 4.0.0 Use {@link JMX_REPORTER
"jmx.reporter"} instead.} */
Review Comment:
Nice find! Did not even know about this one.
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -493,7 +493,8 @@ public class StreamsConfig extends AbstractConfig {
public static final String BUILT_IN_METRICS_VERSION_CONFIG =
"built.in.metrics.version";
private static final String BUILT_IN_METRICS_VERSION_DOC = "Version of the
built-in metrics to use.";
- /** {@code cache.max.bytes.buffering} */
+ /** {@code cache.max.bytes.buffering}
+ * @deprecated since 3.4.0 Use {@link #CACHE_MAX_BYTES_CONFIG
"cache.max.bytes"} instead. */
Review Comment:
```suggestion
* @deprecated since 3.4.0 Use {@link #STATESTORE_CACHE_MAX_BYTES_CONFIG
"statestore.cache.max.bytes"} instead. */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
