mjsax commented on code in PR #15790:
URL: https://github.com/apache/kafka/pull/15790#discussion_r1587028687
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java:
##########
@@ -58,8 +60,14 @@ public void addChild(final ProcessorNode<Void, Void, ?, ?>
child) {
public void init(final InternalProcessorContext<Void, Void> context) {
super.init(context);
this.context = context;
- keySerializer = prepareKeySerializer(keySerializer, context,
this.name());
- valSerializer = prepareValueSerializer(valSerializer, context,
this.name());
+ try {
+ keySerializer = prepareKeySerializer(keySerializer, context,
this.name());
+ valSerializer = prepareValueSerializer(valSerializer, context,
this.name());
+ } catch (final ConfigException e) {
+ throw new ConfigException(String.format("Failed to initialize
serdes for sink node %s", name()), e);
Review Comment:
Should we split this up further, and have two try-catch blocks, one for the
key, and one for the value, to narrow it down further and add key/value as
information to the error message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
