dajac commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1587225960
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1350,6 +1351,7 @@ private
CoordinatorResult<ConsumerGroupHeartbeatResponseData, Record> consumerGr
.withMembers(group.members())
.withStaticMembers(group.staticMembers())
.withSubscriptionMetadata(subscriptionMetadata)
+
.withSubscriptionType(ConsumerGroup.subscriptionType(subscribedTopicNamesMap))
Review Comment:
I was thinking a little more about this one and I still believe that we
should rather do it right after computing `subscribedTopicNamesMap =
group.computeSubscribedTopicNames(member, updatedMember);` because there are
cases where we would end up here but without needing to re-compute it (e.g.
staticMemberReplaced is true).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
