jeffkbkim commented on code in PR #15835:
URL: https://github.com/apache/kafka/pull/15835#discussion_r1588049288
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorRuntimeMetrics.java:
##########
@@ -120,19 +121,14 @@ public GroupCoordinatorRuntimeMetrics(Metrics metrics) {
"The average time it took to load the partitions in the last
30 sec."
), new Avg());
- this.threadIdleRatioSensor = metrics.sensor("ThreadIdleRatio");
- this.threadIdleRatioSensor.add(
- metrics.metricName(
- "thread-idle-ratio-min",
+ this.threadIdleSensor = metrics.sensor("ThreadIdleRatio");
+ this.threadIdleSensor.add(new Meter(TimeUnit.MILLISECONDS,
+ metrics.metricName("thread-idle-ratio",
METRICS_GROUP,
- "The minimum thread idle ratio over the last 30 seconds."
- ), new Min());
- this.threadIdleRatioSensor.add(
- metrics.metricName(
- "thread-idle-ratio-avg",
+ "The fraction of time the threads spent waiting for an
event."),
+ metrics.metricName("thread-idle-time-ms-total",
Review Comment:
Moved to using a Rate instead of Meter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
