mjsax commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1588576144
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -1202,16 +1202,47 @@ public class StreamsConfig extends AbstractConfig {
PRODUCER_EOS_OVERRIDES =
Collections.unmodifiableMap(tempProducerDefaultOverrides);
}
+ private static final Map<String, Object> KS_DEFAULT_CONSUMER_CONFIGS;
+ static {
+ final Map<String, Object> tempConsumerDefaultOverrides = new
HashMap<>();
+
tempConsumerDefaultOverrides.put(ConsumerConfig.MAX_POLL_RECORDS_CONFIG,
"1000");
+
tempConsumerDefaultOverrides.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG,
"earliest");
+ tempConsumerDefaultOverrides.put("internal.leave.group.on.close",
false);
+
+ KS_CONTROLLED_CONSUMER_CONFIGS =
Collections.unmodifiableMap(tempConsumerDefaultOverrides);
Review Comment:
We do allow users to modify these configs. I don't think we want to lock it
down?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
