chia7712 commented on code in PR #15861: URL: https://github.com/apache/kafka/pull/15861#discussion_r1590262208
########## core/src/test/java/kafka/test/annotation/ClusterTestDefaults.java: ########## @@ -42,4 +42,5 @@ boolean autoStart() default true; // Set default server properties for all @ClusterTest(s) ClusterConfigProperty[] serverProperties() default {}; + ClusterConfigDisplayTag[] displayTags() default {}; Review Comment: Could we add this to default annotation if we do have such use case? ########## core/src/test/java/kafka/test/annotation/ClusterConfigDisplayTag.java: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package kafka.test.annotation; + +import java.lang.annotation.Documented; +import java.lang.annotation.ElementType; +import java.lang.annotation.Retention; +import java.lang.annotation.RetentionPolicy; +import java.lang.annotation.Target; + +@Documented +@Target({ElementType.ANNOTATION_TYPE}) +@Retention(RetentionPolicy.RUNTIME) +public @interface ClusterConfigDisplayTag { Review Comment: Maybe call it `Tag`? `ClusterConfigDisplayTag` is a bit verbose to me ########## core/src/test/java/kafka/test/ClusterConfig.java: ########## @@ -152,6 +154,9 @@ public MetadataVersion metadataVersion() { public Map<Integer, Map<String, String>> perBrokerOverrideProperties() { return perBrokerOverrideProperties; } + public Map<String, String> displayTags() { Review Comment: Please update `nameTags` ########## core/src/test/java/kafka/test/annotation/ClusterTest.java: ########## @@ -44,4 +44,5 @@ String listener() default ""; MetadataVersion metadataVersion() default MetadataVersion.IBP_3_8_IV0; ClusterConfigProperty[] serverProperties() default {}; + ClusterConfigDisplayTag[] displayTags() default {}; Review Comment: We can remove the `name` field now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org