chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1591866899


##########
core/src/test/java/kafka/test/ClusterConfig.java:
##########
@@ -306,11 +300,16 @@ public Builder setPerBrokerProperties(Map<Integer, 
Map<String, String>> perBroke
             return this;
         }
 
+        public Builder setTags(String[] tags) {

Review Comment:
   We use `Array` in annotation, but it would be better to use `List` here.



##########
core/src/test/java/kafka/test/ClusterConfig.java:
##########
@@ -153,15 +148,19 @@ public Map<Integer, Map<String, String>> 
perBrokerOverrideProperties() {
         return perBrokerOverrideProperties;
     }
 
-    public Map<String, String> nameTags() {
-        Map<String, String> tags = new LinkedHashMap<>(4);
-        name().ifPresent(name -> tags.put("Name", name));
-        tags.put("MetadataVersion", metadataVersion.toString());
-        tags.put("Security", securityProtocol.name());
-        listenerName().ifPresent(listener -> tags.put("Listener", listener));
+    public String[] tags() {
         return tags;
     }
 
+    public Map<String, String> nameTags() {

Review Comment:
   Could you please add the `tags` to this method? Also, it would be great to 
rename it to "displayName", and the return type should be `String` instead of 
`Map<String, String>`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to