clolov commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1592114443


##########
core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala:
##########
@@ -219,7 +219,7 @@ class ListOffsetsRequestTest extends BaseRequestTest {
     TestUtils.generateAndProduceMessages(servers, topic, 9)
     TestUtils.produceMessage(servers, topic, "test-10", 
System.currentTimeMillis() + 10L)
 
-    for (version <- ApiKeys.LIST_OFFSETS.oldestVersion to 
ApiKeys.LIST_OFFSETS.latestVersion) {
+    for (version <- ApiKeys.LIST_OFFSETS.oldestVersion to 
ApiKeys.LIST_OFFSETS.latestVersion(false)) {

Review Comment:
   I want to hide the latest unstable version of the ListOffsetRequest from 
everywhere. A follow-up pull request will allow it to be called and introduce 
the changes needed for the client to call with this a newer OffsetSpec and a 
test confirming the behaviour. Does this make sense or am I misunderstanding 
the question?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to