AyoubOm commented on code in PR #15607:
URL: https://github.com/apache/kafka/pull/15607#discussion_r1592386867
##########
streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java:
##########
@@ -244,21 +248,21 @@ public void doJoinFromLeftThenDeleteLeftEntity() {
);
}
}
- // Now delete one LHS entity such that one delete is propagated
down to the output.
- left.pipeInput("lhs1", (String) null, baseTimestamp + 6);
+ // Now delete one LHS entity such that one delete is propagated
down to the output.
+ left.pipeInput("lhs1", null, baseTimestamp + 6);
assertThat(
- outputTopic.readKeyValuesToMap(),
- is(mkMap(
- mkEntry("lhs1", null)
+ outputTopic.readKeyValuesToList(),
+ is(Collections.singletonList(
+ KeyValue.pair("lhs1", null)
))
);
if (rejoin) {
assertThat(
- rejoinOutputTopic.readKeyValuesToMap(),
- is(mkMap(
- mkEntry("lhs1", null)
- ))
+ rejoinOutputTopic.readKeyValuesToList(),
+ hasItem(
Review Comment:
Not testing all items because the test is not deterministic, it may or may
not contain `("lhs1", "rejoin((lhsValue1|rhs1,rhsValue1),null)")` depending on
whether it's the left hand or the right hand side of the final join which
propagates first.
`rejoin` is computed this way in the test:
___________LEFT
| |
| RIGHT |
| | |
\ / /
\ / /
\ / /
FKJoin /
\ /
\ /
Rejoin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
