showuon commented on code in PR #15884:
URL: https://github.com/apache/kafka/pull/15884#discussion_r1593636792
##########
tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java:
##########
@@ -160,28 +154,26 @@ private String outputWithoutEpoch(String output) {
int pos = output.indexOf("Epoch: ");
return (pos > 0) ? output.substring(0, pos) : output;
}
-}
-class FeatureCommandUnitTest {
Review Comment:
ditto, adding comments to make it clear the following tests are unit tests.
##########
tools/src/test/java/org/apache/kafka/tools/DeleteRecordsCommandTest.java:
##########
@@ -112,12 +107,7 @@ private static void executeAndAssertOutput(String json,
String expOut, Admin adm
});
assertTrue(output.contains(expOut));
}
-}
-/**
- * Unit test of {@link DeleteRecordsCommand} tool.
- */
Review Comment:
I would keep the comment to make it clear the following tests are unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
