lucasbru commented on code in PR #15894:
URL: https://github.com/apache/kafka/pull/15894#discussion_r1593911025
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -954,8 +954,7 @@ private void recycleTaskFromStateUpdater(final Task task,
}
}
- /** Returns true if the task closed clean */
- private boolean closeTaskClean(final Task task,
+ private void closeTaskClean(final Task task,
final Set<Task> tasksToCloseDirty,
Review Comment:
indentation
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -149,14 +149,25 @@ public void run() {
} catch (final RuntimeException anyOtherException) {
handleRuntimeException(anyOtherException);
} finally {
- removeAddedTasksFromInputQueue();
- removeUpdatingAndPausedTasks();
+ clearInputQueue();
+ updatingTasks.clear();
+ pausedTasks.clear();
+ changelogReader.clear();
Review Comment:
why was this added? Where was it executed before?
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -787,9 +796,12 @@ public DefaultStateUpdater(final String name,
this.log = logContext.logger(DefaultStateUpdater.class);
}
- @Override
public void start() {
if (stateUpdaterThread == null) {
+ if (!restoredActiveTasks.isEmpty() ||
!exceptionsAndFailedTasks.isEmpty()) {
Review Comment:
why did you add this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
