FrankYang0529 opened a new pull request, #15897: URL: https://github.com/apache/kafka/pull/15897
Both ClusterType#ALL and ClusterType#DEFAULT are a kind of "tag" instead of true "type". It seems to me they can be removed by using Array. For example: ClusterType#ALL -> {Type.ZK, Type.KRAFT, Type.CO_KRAFT} ClusterType#DEFAULT -> {} There are two benefits 1. That is more readable for "ALL type". 2. We don't throw the awkward "exception" when seeing "DEFAULT". ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org