jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1595910078
##########
raft/src/main/java/org/apache/kafka/snapshot/RecordsSnapshotReader.java:
##########
@@ -145,9 +147,7 @@ private Optional<Batch<T>> nextBatch() {
);
}
- if (!batch.records().isEmpty()) {
- return Optional.of(batch);
- }
+ return Optional.of(batch);
Review Comment:
Yes. Good catch. We need an `if` statement. I updated the java doc too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
