FrankYang0529 commented on code in PR #15897:
URL: https://github.com/apache/kafka/pull/15897#discussion_r1596463798
##########
core/src/test/java/kafka/test/annotation/ClusterTest.java:
##########
@@ -33,7 +33,7 @@
@Retention(RUNTIME)
@TestTemplate
public @interface ClusterTest {
- Type clusterType() default Type.DEFAULT;
+ Type[] clusterTypes() default {};
Review Comment:
Hi @lianetm, thanks for your review and suggestion. I agree we should use
all types by default, but it should be in `ClusterTestDefaults`. The reason is
that we will use whether `ClusterTest#clusterTypes` is empty to determine using
`ClusterTest` or `ClusterTestDefaults`. If `ClusterTest#clusterTypes` is not
empty by default, users may need to specify `clusterTypes={}` to use
`ClusterTestDefaults`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
