junrao commented on code in PR #15912:
URL: https://github.com/apache/kafka/pull/15912#discussion_r1596962906
##########
raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java:
##########
@@ -256,7 +256,7 @@ public void appendControlMessages(MemoryRecordsCreator
valueCreator) {
}
private int validateMemoryRecordAndReturnCount(MemoryRecords memoryRecord)
{
- // Confirm that it is at most one batch and it is a control record
+ // Confirm that it is one control batch and it is at least one control
record
Review Comment:
validateMemoryRecordAndReturnCount => validateMemoryRecordsAndReturnCount
memoryRecord => memoryRecords
Also, there is an existing typo creatte on line 268.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
