flashmouse commented on code in PR #13965:
URL: https://github.com/apache/kafka/pull/13965#discussion_r1599510047
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java:
##########
@@ -739,8 +750,13 @@ private void
assignRackAwareRoundRobin(List<TopicPartition> unassignedPartitions
int firstIndex =
rackInfo.nextRackConsumer(unassignedPartition,
unfilledMembersWithExactlyMinQuotaPartitions, 0);
if (firstIndex >= 0) {
consumer =
unfilledMembersWithExactlyMinQuotaPartitions.get(firstIndex);
- if (assignment.get(consumer).size() + 1 == maxQuota)
+ if (assignment.get(consumer).size() + 1 == maxQuota) {
unfilledMembersWithExactlyMinQuotaPartitions.remove(firstIndex);
+ currentNumMembersWithOverMinQuotaPartitions++;
+ if (currentNumMembersWithOverMinQuotaPartitions ==
expectedNumMembersWithOverMinQuotaPartitions) {
Review Comment:
comment could be useful, added it. plz check again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
