[
https://issues.apache.org/jira/browse/KAFKA-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574622#comment-16574622
]
Andras Katona commented on KAFKA-7134:
--------------------------------------
My pull request's review/acceptance is a bit stuck, let me summarise it here as
well.
I've introduced two new config parameters to the log appender:
* *ignoreExceptions* - by default it is not ignoring exceptions thrown by the
producer, has to be true in order to ignore them
* *maxBlockMs* - it is introduced basically just to be able to test the
ignoreExceptions parameter more efficiently with real log appender, without a
producer behind it. By default it is 60 sec (that would be too much to wait in
tests)
Regarding reviews, after a few iterations, the change is fine, although there
is a question in this conversation, which is not answered yet.
[https://github.com/apache/kafka/pull/5415#discussion_r207178978]
Asked by [~rsivaram] from [~ijuma]
{quote}[@ijuma|https://github.com/ijuma] Do we use KIPs for adding configs to
{{KafkaLog4jAppender}} ({{ignoreExceptions}} and {{timeout}} here)?
{quote}
*Note:* {{timeout}} is renamed to {{maxBlockMs}}
[~ijuma], could you check whether we need a KIP for these changes? I hope not,
since this is a minor enhancement, but I'm looking forward to your answer.
Thanks!
> KafkaLog4jAppender - Appender exceptions are propagated to caller
> -----------------------------------------------------------------
>
> Key: KAFKA-7134
> URL: https://issues.apache.org/jira/browse/KAFKA-7134
> Project: Kafka
> Issue Type: Bug
> Components: clients
> Reporter: venkata praveen
> Assignee: Andras Katona
> Priority: Major
>
> KafkaLog4jAppender exceptions are propagated to caller when Kafka is
> down/slow/other, it may cause the application crash. Ideally appender should
> print and ignore the exception
> or should provide option to ignore/throw the exceptions like
> 'ignoreExceptions' property of
> https://logging.apache.org/log4j/2.x/manual/appenders.html#KafkaAppender
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
