yashmayya commented on code in PR #15865:
URL: https://github.com/apache/kafka/pull/15865#discussion_r1603105885


##########
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaStatusBackingStore.java:
##########
@@ -160,7 +155,7 @@ public KafkaStatusBackingStore(Time time, Converter 
converter, Supplier<TopicAdm
 
     // visible for testing
     KafkaStatusBackingStore(Time time, Converter converter, String 
statusTopic, KafkaBasedLog<String, byte[]> kafkaLog) {
-        this(time, converter);
+        this(time, converter, null, "connect-distributed-");

Review Comment:
   Yeah, that's a good point. I think this and the "`ownTopicAdmin`" are cruft 
left over from earlier refactors and are definitely no longer used anywhere in 
Connect itself (or MM2). Since these aren't part of Connect's public API, I 
think we should be fine with removing them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to