chia7712 commented on code in PR #15916:
URL: https://github.com/apache/kafka/pull/15916#discussion_r1605371498
##########
core/src/test/java/kafka/test/ClusterTestExtensionsTest.java:
##########
@@ -62,10 +63,10 @@ public class ClusterTestExtensionsTest {
}
// Static methods can generate cluster configurations
- static void generate1(ClusterGenerator clusterGenerator) {
+ static List<ClusterConfig> generate1() {
Map<String, String> serverProperties = new HashMap<>();
serverProperties.put("foo", "bar");
- clusterGenerator.accept(ClusterConfig.defaultBuilder()
+ return Arrays.asList(ClusterConfig.defaultBuilder()
Review Comment:
`Collections.singletonList`
##########
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##########
@@ -122,31 +115,57 @@ public Stream<TestTemplateInvocationContext>
provideTestTemplateInvocationContex
return generatedContexts.stream();
}
- void processClusterTemplate(ExtensionContext context, ClusterTemplate
annot,
-
Consumer<TestTemplateInvocationContext> testInvocations) {
+
+
+ List<TestTemplateInvocationContext>
processClusterTemplate(ExtensionContext context, ClusterTemplate annot) {
// If specified, call cluster config generated method (must be static)
List<ClusterConfig> generatedClusterConfigs = new ArrayList<>();
Review Comment:
Please remove this unused variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
