mjsax commented on code in PR #14448: URL: https://github.com/apache/kafka/pull/14448#discussion_r1605892956
########## docs/streams/developer-guide/config-streams.html: ########## @@ -261,10 +261,10 @@ <h4><a class="toc-backref" href="#id23">num.standby.replicas</a><a class="header </tr> <tr class="row-odd"><td>statestore.cache.max.bytes</td> <td>Medium</td> - <td colspan="2">Maximum number of memory bytes to be used for record caches across all threads.</td> + <td colspan="2">Maximum number of memory bytes to be used for record caches across all threads. Note that at the debug level you can use <code>cache.size</code> to monitor the actual size of the Kafka Streams cache.</td> <td>10485760</td> </tr> - <tr class="row-even"><td>cache.max.bytes.buffering (Deprecated. Use statestore.cache.max.bytes instead.)</td> + <tr class="row-even"><td>cache.max.bytes.buffering (Deprecated. Use cache.max.bytes instead.)</td> Review Comment: Seem `statestore.cache.max.bytes` is correct? ########## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ########## @@ -658,7 +660,7 @@ public class StreamsConfig extends AbstractConfig { public static final String METRICS_SAMPLE_WINDOW_MS_CONFIG = CommonClientConfigs.METRICS_SAMPLE_WINDOW_MS_CONFIG; /** {@code auto.include.jmx.reporter} - * @deprecated and will be removed in 4.0.0 */ + * @deprecated and will removed in 4.0.0 Users should instead include org.apache.kafka.common.metrics.JmxReporter in metric.reporters in order to enable the JmxReporter.} */ Review Comment: ```suggestion * @deprecated and be will removed in 4.0.0; include {@link org.apache.kafka.common.metrics.JmxReporter} via config {@code metric.reporters} in order to enable the JmxReporter. */ ``` ########## docs/streams/developer-guide/config-streams.html: ########## @@ -307,25 +307,23 @@ <h4><a class="toc-backref" href="#id23">num.standby.replicas</a><a class="header set by the user or all serdes must be passed in explicitly (see also default.key.serde).</td> <td><code class="docutils literal"><span class="pre">null</span></code></td> </tr> - <tr class="row-even"><td>default.windowed.key.serde.inner (Deprecated. Use windowed.inner.class.serde instead.)</td> - <td>Medium</td> - <td colspan="2">Default serializer/deserializer for the inner class of windowed keys, implementing the <code class="docutils literal"><span class="pre">Serde</span></code> interface.</td> - <td><code class="docutils literal"><span class="pre">null</span></code></td> - </tr> - <tr class="row-odd"><td>default.windowed.value.serde.inner (Deprecated. Use windowed.inner.class.serde instead.)</td> + <tr class="row-even"><td>default.windowed.key.serde.inner (Deprecated.)</td> Review Comment: Seems we don't need this line? It's duplicated above and below? ########## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ########## @@ -500,7 +500,9 @@ public class StreamsConfig extends AbstractConfig { private static final String BUILT_IN_METRICS_VERSION_DOC = "Version of the built-in metrics to use."; /** {@code cache.max.bytes.buffering} + Review Comment: nit: about unnecessary empty lines (same right below) ########## docs/streams/developer-guide/config-streams.html: ########## @@ -307,25 +307,23 @@ <h4><a class="toc-backref" href="#id23">num.standby.replicas</a><a class="header set by the user or all serdes must be passed in explicitly (see also default.key.serde).</td> <td><code class="docutils literal"><span class="pre">null</span></code></td> </tr> - <tr class="row-even"><td>default.windowed.key.serde.inner (Deprecated. Use windowed.inner.class.serde instead.)</td> Review Comment: Why does this PR remove this row in the table? ########## docs/streams/developer-guide/config-streams.html: ########## @@ -261,10 +261,10 @@ <h4><a class="toc-backref" href="#id23">num.standby.replicas</a><a class="header </tr> <tr class="row-odd"><td>statestore.cache.max.bytes</td> <td>Medium</td> - <td colspan="2">Maximum number of memory bytes to be used for record caches across all threads.</td> + <td colspan="2">Maximum number of memory bytes to be used for record caches across all threads. Note that at the debug level you can use <code>cache.size</code> to monitor the actual size of the Kafka Streams cache.</td> Review Comment: Not clear to me, what the added sentence means? Are you referring to JMX metrics? ########## docs/streams/developer-guide/config-streams.html: ########## @@ -307,25 +307,23 @@ <h4><a class="toc-backref" href="#id23">num.standby.replicas</a><a class="header set by the user or all serdes must be passed in explicitly (see also default.key.serde).</td> <td><code class="docutils literal"><span class="pre">null</span></code></td> </tr> - <tr class="row-even"><td>default.windowed.key.serde.inner (Deprecated. Use windowed.inner.class.serde instead.)</td> - <td>Medium</td> - <td colspan="2">Default serializer/deserializer for the inner class of windowed keys, implementing the <code class="docutils literal"><span class="pre">Serde</span></code> interface.</td> - <td><code class="docutils literal"><span class="pre">null</span></code></td> - </tr> - <tr class="row-odd"><td>default.windowed.value.serde.inner (Deprecated. Use windowed.inner.class.serde instead.)</td> + <tr class="row-even"><td>default.windowed.key.serde.inner (Deprecated.)</td> + Review Comment: nit: remove empty line ########## docs/streams/developer-guide/config-streams.html: ########## @@ -307,25 +307,23 @@ <h4><a class="toc-backref" href="#id23">num.standby.replicas</a><a class="header set by the user or all serdes must be passed in explicitly (see also default.key.serde).</td> <td><code class="docutils literal"><span class="pre">null</span></code></td> </tr> - <tr class="row-even"><td>default.windowed.key.serde.inner (Deprecated. Use windowed.inner.class.serde instead.)</td> - <td>Medium</td> - <td colspan="2">Default serializer/deserializer for the inner class of windowed keys, implementing the <code class="docutils literal"><span class="pre">Serde</span></code> interface.</td> - <td><code class="docutils literal"><span class="pre">null</span></code></td> - </tr> - <tr class="row-odd"><td>default.windowed.value.serde.inner (Deprecated. Use windowed.inner.class.serde instead.)</td> + <tr class="row-even"><td>default.windowed.key.serde.inner (Deprecated.)</td> + + <tr class="row-odd"><td>default.windowed.key.serde.inner (Deprecated. Use windowed.inner.class.serde instead.)</td> Review Comment: duplicated line? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org