jolshan commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r1607383820
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -1361,10 +1366,10 @@ class ReplicaManager(val config: KafkaConfig,
*/
private def appendToLocalLog(internalTopicsAllowed: Boolean,
origin: AppendOrigin,
- entriesPerPartition: Map[TopicPartition,
MemoryRecords],
+ entriesPerPartition: Map[TopicIdPartition,
MemoryRecords],
Review Comment:
is there a reason to pass this data structure here if we are not using the
ID to check the append at the log level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
