[
https://issues.apache.org/jira/browse/KAFKA-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576926#comment-16576926
]
ASF GitHub Bot commented on KAFKA-6998:
---------------------------------------
guozhangwang opened a new pull request #5488: KAFKA-6998: Disable Caching when
max.cache.bytes are zero.
URL: https://github.com/apache/kafka/pull/5488
1. As titled, add a `rewriteTopology` that 1) sets application id, 2) maybe
disable caching, 3) adjust for source KTable. This optimization can hence be
applied for both DSL or PAPI generated Topology.
2. Defer the building of globalStateStores in `rewriteTopology` so that we
can also disable caching. But we still need to build the state stores before
`InternalTopologyBuilder.build()` since we should only build global stores once
for all threads.
3. Added withCachingDisabled to StoreBuilder, it is a public API change.
4. [Optional] Fixed unit test config setting functionalities, and set the
necessary config to shorten the unit test latency (now it reduces from 5min to
3.5min on my laptop).
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove caching wrapper stores if cache-size is configured to zero bytes
> -----------------------------------------------------------------------
>
> Key: KAFKA-6998
> URL: https://issues.apache.org/jira/browse/KAFKA-6998
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: Matthias J. Sax
> Priority: Major
>
> Users can disable caching globally by setting the cache size to zero in their
> config. However, this does only effectively disable the caching layer, but
> the code is still in place.
> We should consider to remove the caching wrappers completely for this case.
> The tricky part is, that we insert the caching layer at compile time, ie,
> when calling `StreamsBuilder#build()` – at this point, we don't know the
> configuration yet. Thus, we need to find a way to rewrite the topology after
> it is passed to `KafkaStreams` if case caching size is set to zero.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
