showuon commented on code in PR #15516:
URL: https://github.com/apache/kafka/pull/15516#discussion_r1607924069
##########
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##########
@@ -173,6 +173,14 @@ public class TopicConfig {
"accepts 'uncompressed' which is equivalent to no compression; and
'producer' which means retain the " +
"original compression codec set by the producer.";
+
+ public static final String COMPRESSION_GZIP_LEVEL_CONFIG =
"compression.gzip.level";
+ public static final String COMPRESSION_GZIP_LEVEL_DOC = "The compression
level to use if " + COMPRESSION_TYPE_CONFIG + " is set to <code>gzip</code>.";
+ public static final String COMPRESSION_LZ4_LEVEL_CONFIG =
"compression.lz4.level";
+ public static final String COMPRESSION_LZ4_LEVEL_DOC = "The compression
level to use if " + COMPRESSION_TYPE_CONFIG + " is set to <code>lz4</code>.";
+ public static final String COMPRESSION_ZSTD_LEVEL_CONFIG =
"compression.zstd.level";
+ public static final String COMPRESSION_ZSTD_LEVEL_DOC = "The compression
level to use if " + COMPRESSION_TYPE_CONFIG + " is set to <code>zstd</code>.";
Review Comment:
I was thinking we added in the config description. Or maybe added in KIP-390
is good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
