chia7712 commented on code in PR #15838: URL: https://github.com/apache/kafka/pull/15838#discussion_r1608469438
########## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ########## @@ -303,17 +303,17 @@ class DynamicBrokerConfig(private val kafkaConfig: KafkaConfig) extends Logging addBrokerReconfigurable(controller.socketServer) } - def addReconfigurable(reconfigurable: Reconfigurable): Unit = CoreUtils.inWriteLock(lock) { + def addReconfigurable(reconfigurable: Reconfigurable): Unit = { verifyReconfigurableConfigs(reconfigurable.reconfigurableConfigs.asScala) Review Comment: @cmccabe Can we remove the lock from `verifyReconfigurableConfigs` in this PR? Or we can address that in next one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org