gharris1727 commented on code in PR #16016:
URL: https://github.com/apache/kafka/pull/16016#discussion_r1608820947
##########
build.gradle:
##########
@@ -341,7 +341,7 @@ subprojects {
artifact task
}
- artifactId = archivesBaseName
+ artifactId =
project.extensions.findByType(BasePluginExtension)?.archivesName?.get()
Review Comment:
I think this has the same effect, and looks a bit better. The "safe
navigation operator" `?` also makes me think that this could be null, when it
really should never be null, and the publishing plugin can't handle a null.
```suggestion
artifactId = base.archivesName.get()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
